Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present in-app browser as sheet #5718

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Present in-app browser as sheet #5718

merged 3 commits into from
Oct 11, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Oct 11, 2024

Presents in-app browser as sheet

Commit 1 has the meaty changes 2ae83fa
The other commits move the hook out of preferences, since that was a weird place for it to be

@arcalinea arcalinea temporarily deployed to samuel/iab-improvements - social-app PR #5718 October 11, 2024 11:32 — with Render Destroyed
@mozzius mozzius changed the title Samuel/iab improvements Present in-app browser as sheet Oct 11, 2024
Copy link

Old size New size Diff
7.89 MB 7.89 MB 0 B (0.00%)

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works & feels great

@pfrazee pfrazee merged commit d632247 into main Oct 11, 2024
6 checks passed
@pfrazee pfrazee deleted the samuel/iab-improvements branch October 11, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants