Fix keyboard hiding alt text input after viewing DMs on iOS #5739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eaba658.
arcalinea
temporarily deployed
to
hailey/fix-alt-for-real - social-app PR #5739
Render
Destroyed
|
mozzius
approved these changes
Oct 14, 2024
haileyok
added a commit
that referenced
this pull request
Oct 14, 2024
(cherry picked from commit 432dc86)
haileyok
added a commit
that referenced
this pull request
Oct 14, 2024
(cherry picked from commit 432dc86)
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5705
Why
Extremely weird case, but the
react-native-keyboard-controllerlibrary requires us to do this here, since we enable and then disable it on the DMs screen. If we don't do so when opening/closing a dialog as well, we get into a weird state where the scrollview doesn't resize appropriately when needed.Eventually, this won't be needed at all (see open draft PR for fully handling the scroll in swift) but for now let's do this since it's an easy OTA patch.
Test Plan
Observe the current behavior and the new behavior.
Current
Screen.Recording.2024-10-13.at.11.20.58.PM.mov
New
Screen.Recording.2024-10-13.at.11.23.31.PM.mov