Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix starter pack text overflow #5891

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix starter pack text overflow #5891

merged 1 commit into from
Oct 28, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Oct 21, 2024

just a silly flexbox issue

Before After
Simulator Screenshot - iPhone 16 - 2024-10-21 at 19 46 58 Simulator Screenshot - iPhone 16 - 2024-10-21 at 19 46 47

@github-actions GitHub Actions
Copy link

Old size New size Diff
7.9 MB 7.9 MB 18 B (0.00%)

@arcalinea arcalinea temporarily deployed to samuel/sp-text-wrap - social-app PR #5891 October 24, 2024 20:08 — with Render Destroyed
haileyok
haileyok approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small things we may want to hit:

  • numberOfLines set to 2 for the title?
  • numberOfLines set to 1 for the Starter pack by...

Think that follows what we do in other places.

@mozzius mozzius merged commit 1c992be into main Oct 28, 2024
6 checks passed
@mozzius mozzius deleted the samuel/sp-text-wrap branch October 28, 2024 16:28
@haileyok haileyok mentioned this pull request Oct 28, 2024
Merged
rshigg pushed a commit to rshigg/social-app that referenced this pull request Nov 2, 2024
@mozzius @rshigg
flex_1 text container (bluesky-social#5891)
b386a76
rshigg pushed a commit to rshigg/social-app that referenced this pull request Nov 2, 2024
@mozzius @rshigg
flex_1 text container (bluesky-social#5891)
d9137e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyok haileyok haileyok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mozzius @haileyok @arcalinea