Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newskies badge to skeets and DMs #5899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oracularhades20
Copy link

Screenshot 2024-10-22 at 7 17 36 PM Screenshot 2024-10-22 at 7 13 39 PM Screenshot 2024-10-22 at 7 13 30 PM Screenshot 2024-10-22 at 7 09 58 PM

Issues with this:

  • The badge won't appear on the DMs conversations list because createdAt isn't returned. There is a conditional render so that it will automatically start working when it is returned.
  • The newskies badge is only 7 days, Bossett's is 30. I'd suggest the 7 day limit gets upped to 30, though we should be mindful of that fact new users will join and get called newskies for ages. I've left it up for everyone to decide how that should work.
  • The badge should maybe have a slightly different colour?
  • The sizing is off in some areas, this is because it didn't have a styling prop or css class.

Bossett's kangaroos can go back to fighting them rather than getting ratelimited labeling newskies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants