Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add en-GB localisation #5952

Merged
merged 9 commits into from
Oct 28, 2024
Merged

Conversation

surfdude29
Copy link
Contributor

This PR adds a localisation for en-GB (British English).

The main advantage of this is that it would enable users who have their locale set to en-GB to view dates in dd/mm/yy format instead of the en default of mm/dd/yy.

It also includes adaptations – mostly minor spelling differences – for 27 strings as follows:

  • behavior ➡️ behaviour
  • captions ➡️ subtitles
  • color ➡️ colour
  • customize ➡️ customise
  • favorite ➡️ favourite
  • finalizing ➡️ finalising
  • honor ➡️ honour
  • labeled ➡️ labelled
  • labeler ➡️ labeller
  • movies ➡️ films
  • prioritize ➡️ prioritise

The first commit a0e994d uses the updated en message catalogue from #5908 as a base.

The second commit 6aaf790 contains the actual en-GB string adaptations.

And the remaining commits make the necessary changes to other files to enable the localisation.

That other site, Mastodon and Threads all have British English localisations, so why not Bluesky?

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @mozzius I can't read british can you confirm these for me

@pfrazee pfrazee merged commit 498b83a into bluesky-social:main Oct 28, 2024
6 checks passed
@surfdude29 surfdude29 deleted the add-en-gb-localisation branch October 29, 2024 00:47
rshigg pushed a commit to rshigg/social-app that referenced this pull request Nov 2, 2024
* Create blank en-GB/messages.po

* localise certain strings for en-GB

* Update lingui.config.js

* Update dates.ts

* Update helpers.ts

* Update i18n.ts

* Update i18n.web.ts

* Update languages.ts

* Update i18n.ts
rshigg pushed a commit to rshigg/social-app that referenced this pull request Nov 2, 2024
* Create blank en-GB/messages.po

* localise certain strings for en-GB

* Update lingui.config.js

* Update dates.ts

* Update helpers.ts

* Update i18n.ts

* Update i18n.web.ts

* Update languages.ts

* Update i18n.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants