Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render ComposerPills when unnecessary #5975

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

haileyok
Copy link
Contributor

Why

When replying to a post, we should only render <ComposerPills> whenever there is media in the image. Right now, even though the pill itself doesn't get rendered, the container does and displays a border.

Test Plan

  • Replying to a post shouldn't render the extra border at the bottom
    • If you add an image to the post, it should render and the "Label" button should appear
  • Creating a new post should always render pill container

@arcalinea arcalinea temporarily deployed to hailey/fix-bottom-bar-composer - social-app PR #5975 October 28, 2024 18:00 — with Render Destroyed
Copy link

Old size New size Diff
7.91 MB 7.91 MB 15 B (0.00%)

@haileyok haileyok merged commit 2e3844c into main Oct 28, 2024
6 checks passed
rshigg pushed a commit to rshigg/social-app that referenced this pull request Nov 2, 2024
rshigg pushed a commit to rshigg/social-app that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants