Fix double padding in Dialog.InnerFlatList on web
#5986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozzius
commented
Oct 28, 2024
src/components/Dialog/index.web.tsx
Outdated
| webInnerStyle, | ||
| ]}> | ||
| ]} | ||
| contentContainerStyle={[a.px_0]}> |
There was a problem hiding this comment.
This is the main line, the rest are cleanups
There was a problem hiding this comment.
Seems good, I think we want to also pass in the contentContainerStyle from props here too though.
|
arcalinea
temporarily deployed
to
samuel/flatlist-padding - social-app PR #5986
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the structure of
Dialog.Inneraround so padding works differently now. Unfortunately,Dialog.InnerFlatListtries to remove the horizontal padding, which then stopped working. This uses the correct prop to return the style to how it was