-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AT URIs as alternate links #6033
Add AT URIs as alternate links #6033
Conversation
I'm default ok with this, though it feels a bit under-specified. Should there be a There is a small related tension with AT URIs not quite being valid "URL" syntax, following WHATWG standards: https://url.spec.whatwg.org/ The issue is that there are multiple colons in the DID in the "authority" segment of the URI. I think there is a path to relaxing the spec to allow this specific pattern (DIDs in that part of URL), but it will be a delicate conversation: browsers have tons of noisy inbound requests and it is important to be diplomatic and make a clear case. Anyways, probably none of that is a reason not to go ahead with this. Be bold! |
shouldn't profiles link to it seems very ambiguous, what does
I'm not sure if it's a good idea to interpret this change sets a precedent for apps/extensions registering a handler or sniffing for a specific URI, and it'd be bad when we do have multiple extensions/apps checking for this specific URI, because the URI doesn't specify what we actually want to show. |
@mary-ext I think that I don't think that having a In practical terms, it does probably make more sense to tie (note that this codebase could be forked/white-labeled to run on other domains; in that case the relevant thing is still probably the |
FWIW, I think it would also be fine/appropriate to have both a ref to the bsky profile record, and the atproto account identifier. Or even just the bare DID. |
Aren't brackets acceptable for URLs? Like, an ipv6 URL looks like |
Note
I'm not sure how to test this or if this is where the change needs to actually go. I've pattern matched against the received HTML in prod and found these files, so let me know if it's incorrect and I'll rework this!
See likeandscribe/frontpage#172 for the description of why I'd like to make this change.
Some extra discussion here: https://bsky.app/profile/did:plc:2xau7wbgdq4phuou2ypwuen7/post/3l7esaih44s2s