Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings] Add subdomain to _atproto host on change handle #6066

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Settings] Add subdomain to _atproto host on change handle #6066

wants to merge 1 commit into from
+14 −2

Conversation

bogdaaamn
Copy link

@bogdaaamn bogdaaamn commented Nov 1, 2024 •
edited
Loading

Reproduce

  1. Visit your account settings: https://bsky.app/settings
  2. Select Account > Handle
  3. Press I have my own domain ->
  4. Enter custom domain with subdomain, for example sub.bogdan.covrig.dev

The DNS record text output will include the subdomain in the Host field.

Before

382391637-9d224c30-bc73-4fef-9038-021dc2b0eb0b

After

382391764-ab7ff756-08b4-4090-b25e-3bc9c8e08215

Closes #5821.

kankenny
kankenny reviewed Nov 1, 2024
View reviewed changes
Copy link

@kankenny kankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kankenny kankenny kankenny left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS record information does not correctly reflect subdomain
2 participants
@bogdaaamn @kankenny