Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving focus outlines followup #6080

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Improving focus outlines followup #6080

wants to merge 8 commits into from

Conversation

Tahul
Copy link
Contributor

@Tahul Tahul commented Nov 2, 2024 •
edited
Loading

followup of #6061

just made a tour of all parts accessible on desktop/web and added some few fixes

done:

  • tried to fix the UserAvatar wrapping by using tabindex to set focus on the image so the outline wraps around it
  • add outset atom as well to avoid the focus outline to overflow the text

todo:

  • fix the settings dropdown button that has two tabindex spots

CleanShot 2024-11-02 at 15 23 20@2x
CleanShot 2024-11-02 at 15 23 30@2x

  • fix the select in language settings as they cannot be tab focused

CleanShot 2024-11-02 at 15 25 59@2x

@Tahul Tahul force-pushed the feat/focus-outlines-followup branch from db8916c to d7e90ad Compare November 2, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tahul @gaearon