-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to animated lightbox #6088
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't really need the only existing xplat usage of it (but it *was* causing bugs).
It's too hard to make closing while zoomed out work.
This was referenced Nov 3, 2024
Closed
|
Reanimated values and React props were out of sync. Prepare each image's styles separately to avoid that.
Also fix handling of missing aspectRatio
gaearon
force-pushed
the
images-followup-alt
branch
from
November 3, 2024 05:11
42d917e
to
d8eaf8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #6047, #6073, #6048, and #6081
Known issues
Fixes for known issues in the preceding stack. It would've been a pain to rebase and I had to be very careful not to break other things. This seems to be an equilibrium of features working but it's quite fragile. See commit by commit.
Test Plan
All of the above. Plus the usual. Try portraits/landscapes in different layouts (1, 2, 3, 4). Slow down if needed to verify animation.
ok.mov
okay.mov