Add tiktok embed #6092
Open
Add tiktok embed #6092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I noticed that Tiktok links had no embed option, and even the link preview card looked very raw, then on a comment on #2314, @haileyok make some points about the Tiktok embeds. While searching a possible solution, I found out that now tiktok offers an embed player, and it was quite simple to add. While at it, I solved an issue with shortened Tiktok links that wouldn't return the page metadata due to an 301 redirect. This commits solves both the short
vm.tiktok.comlink and the embed to allow viewing Tiktok videos on the feed.Demo
1103.mp4