Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js to 20.x in Dockerfile #6099

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 4, 2024

Refs: https://bsky.app/profile/yagiznizipli.com/post/3l7yibgike52z

Node.js 18.x will be reaching end-of-life on 2025-04-30
https://github.com/nodejs/Release#release-schedule

This PR proactively attempts to upgrade to newer LTS version.

@mozzius
Copy link
Member

mozzius commented Nov 4, 2024

iirc we've got a dependency which requires it, I'll run the CI and see if it passes

@trivikr
Copy link
Contributor Author

trivikr commented Nov 4, 2024

I went through the CI failures, and had to update node version in .nvmrc

Done in f912ede (#6099)

@trivikr
Copy link
Contributor Author

trivikr commented Nov 5, 2024

The linting job wasn't using the node version from .nvmrc

I updated it in f86634f (#6099)

@trivikr
Copy link
Contributor Author

trivikr commented Nov 6, 2024

The yarn typecheck failure was fixed with a type assertion in 4e36fe0 (#6099)

@trivikr
Copy link
Contributor Author

trivikr commented Nov 11, 2024

The CI is succeeding. Is this good to merge?

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets try it

@gaearon gaearon merged commit 7008f61 into bluesky-social:main Nov 11, 2024
6 checks passed
@trivikr trivikr deleted the node20 branch November 11, 2024 20:10
@trivikr
Copy link
Contributor Author

trivikr commented Nov 11, 2024

Looks like Node.js 20.x had to be updated in Dockerfile.embedr too

I've posted a PR at #6242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants