Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ENV key=value in Dockerfile #6100

Merged
merged 4 commits into from
Nov 9, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 4, 2024

This will fix workflow failure

#21 ERROR: failed to push ***/bskyweb:ac9d910e1e77c559eff8b32cd8412335f41074f1: failed commit on ref "manifest-sha256:fd35dcfb18dd12d130322733b0d01dbc209a292dfb4941f2e90a8074c24e774f": unexpected status from PUT request to https://***/v2/bskyweb/manifests/sha256:fd35dcfb18dd12d130322733b0d01dbc209a292dfb4941f2e90a8074c24e774f: 403 Forbidden
------
 > exporting to image:
------

 1 warning found (use docker --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 20)
ERROR: failed to solve: failed to push ***/bskyweb:ac9d910e1e77c559eff8b32cd8412335f41074f1: failed commit on ref "manifest-sha256:fd35dcfb18dd12d130322733b0d01dbc209a292dfb4941f2e90a8074c24e774f": unexpected status from PUT request to https://***/v2/bskyweb/manifests/sha256:fd35dcfb18dd12d130322733b0d01dbc209a292dfb4941f2e90a8074c24e774f: 403 Forbidden
Error: buildx failed with: ERROR: failed to solve: failed to push ***/bskyweb:ac9d910e1e77c559eff8b32cd8412335f41074f1: failed commit on ref "manifest-sha256:fd35dcfb18dd12d130322733b0d01dbc209a292dfb4941f2e90a8074c24e774f": unexpected status from PUT request to https://***/v2/bskyweb/manifests/sha256:fd35dcfb18dd12d130322733b0d01dbc209a292dfb4941f2e90a8074c24e774f: 403 Forbidden

Example: https://github.com/bluesky-social/social-app/actions/runs/11653248662/job/32445429993#step:7:1252

@trivikr
Copy link
Contributor Author

trivikr commented Nov 9, 2024

The workflow failure is no longer happening because of this specific error
https://github.com/bluesky-social/social-app/actions/workflows/build-and-push-bskyweb-aws.yaml

But it's better to fix it, in case it happens again.

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haileyok haileyok merged commit e73d5c6 into bluesky-social:main Nov 9, 2024
6 checks passed
@trivikr trivikr deleted the dockerfile-env-key-value branch November 9, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants