-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starterpacks): convert to lists #6105
base: main
Are you sure you want to change the base?
feat(starterpacks): convert to lists #6105
Conversation
This is a great start as is. Would be cool to view a visual sample of the starterpack's list subjects on the modal, but that's out of scope for now. |
6b7927b
to
6c659fa
Compare
Chore unnecessary log Improve perf
6c659fa
to
319d867
Compare
Hey @joaomendoncaa! Thanks for the PR! I'll bring this up next week and see what direction we want to take this. |
Awesome, appreciate the feedback! Let me know if there's anything in my power to help speed up the process. |
While this is great, I think the usability would be even better if we can change "convert to list" into "add all to list" (either an existing one or a new one, but for the first version it could be only existing ones). This will allow more flexibility in how starter-packs are used, e.g. if I have a "tech" list and a "history" list, I could add several starter-packs to each one. |
Didn't think of that, that's actually an objectively better version of this — we could make a modal for the purpose (attached sketch). I'd be happy to implement it if any of the members gives me any hint at a potential acceptance for the feature. |
Thanks for considering! I would change the "Convert" in the title to "Add", and replace "Select your Lists" with "Select lists to add to" (or similar) to make it more self-explaining, but other than that, looks great to me! |
This is also a great opportunity to add search on the It's the only problem I'm foreseeing with this direction (ignoring copy, since we can change that at a whim before getting this upstreamed). When the list of Lists starts growing, it will become cumbersome to scroll around looking for a specific list you know you had. |
This was my exact thinking when I made request #5932. In that issue, I tried to really think through reusing as many existing UI concepts as possible. In any case, really glad that someone is working on this! yay! |
Convert Starter Packs to Lists!
This tackles #5970 (also #5932, and #5940). It might seem like a minor annoyance, but the number of likes on the issue(s) shows it's a concern for a lot of people.
Due to its minor impact, I've added the feature tucked into the
OverflowMenu
. The motivation is simple; while there's currently no drawback to unreasonable following numbers, managing that following list will become extremely cumbersome in the future if it's flooded with starterpacks — the issue description goes well into detail on the problem.Thanks to anyone who takes the time to chime in, and feel free to request any changes. 🍻
Feature demo
Arc_73SIzxHiay.mp4