Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility for navigation on web #6120

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Improve accessibility for navigation on web #6120

merged 4 commits into from
Nov 5, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Nov 5, 2024

  • use correct accessibility properties and fix up labels
  • hide the icons
  • group screen content into a <main> - DANGER: this adds a wrapping element to the whole page. Unfortunately React Navigation doesn't do this for us. I recommend checking around the app to see if this breaks any screens. The React Navigation element I'm wrapping appears to just have flex: 1 on it, so it should be fine to add the same

Mobile

Before After
Screenshot 2024-11-05 at 16 22 02 Screenshot 2024-11-05 at 16 22 25

Desktop

Before After
Screenshot 2024-11-05 at 16 27 46 Screenshot 2024-11-05 at 16 26 46

@arcalinea arcalinea temporarily deployed to samuel/nav-a11y - social-app PR #6120 November 5, 2024 16:36 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/nav-a11y - social-app PR #6120 November 5, 2024 16:37 — with Render Destroyed
Copy link

github-actions bot commented Nov 5, 2024

Old size New size Diff
8.12 MB 8.12 MB 730 B (0.01%)

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mozzius mozzius merged commit b0c5a37 into main Nov 5, 2024
6 checks passed
@mozzius mozzius deleted the samuel/nav-a11y branch November 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants