-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvements for posts and notifs loading placeholders #6134
base: main
Are you sure you want to change the base?
improvements for posts and notifs loading placeholders #6134
Conversation
After a bit of UI investigation it looks like most of list placeholders skips entry border. Happy to revert the border addition, if it is an established pattern. 🙂 |
Yea let's skip for consistency (and then maybe add it everywhere haha) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but let's make border work like elsewher
oh no, i completely forgot about this and then independently made similar changes! would you like to update this to the stuff i missed? notably, the randomization is cool |
I have added a bit more randomization to the posts and notification placeholders. For posts, the missing menu icon has been added as well as post content loaders has been tweaked a bit. The placeholder can also include an assets/preview box in some cases. For notifications, there is a chance that the placeholder will became following notification variant, to break up the list a bit. Also the entries have also randomized avatars count. Updated previewsWebKapture.2024-12-01.at.01.35.38.mp4Kapture.2024-12-01.at.02.01.11.mp4MobileSimulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-01.at.01.39.25.mp4Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-01.at.01.29.42.mp4 |
@gaearon The updated version should be up for re-review. 🙂 |
Why
I have spotted that Notifications loading placeholder diverged slightly from feed entry appearance.
Kapture.2024-11-06.at.23.45.49.mp4
How
Tweak sizing of and spacing between loading placeholder elements, add bottom border, randomize second text line width to break up visual repetition a bit.
Preview
Kapture.2024-11-06.at.23.29.58.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-06.at.23.33.10.mp4