Add backdated post indicator #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
samuel/backdate-indicator - social-app PR #6156
Render
Destroyed
|
arcalinea
temporarily deployed
to
samuel/backdate-indicator - social-app PR #6156
Render
Destroyed
surfdude29
reviewed
Nov 8, 2024
surfdude29
reviewed
Nov 8, 2024
arcalinea
temporarily deployed
to
samuel/backdate-indicator - social-app PR #6156
Render
Destroyed
arcalinea
temporarily deployed
to
samuel/backdate-indicator - social-app PR #6156
Render
Destroyed
arcalinea
temporarily deployed
to
samuel/backdate-indicator - social-app PR #6156
Render
Destroyed
arcalinea
temporarily deployed
to
samuel/backdate-indicator - social-app PR #6156
Render
Destroyed
haileyok
approved these changes
Nov 12, 2024
| <Prompt.DescriptionText> | ||
| <Trans> | ||
| This post claims to have been created on{' '} | ||
| <RNText style={[a.font_bold]}>{niceDate(i18n, createdAt)}</RNText>, |
There was a problem hiding this comment.
Small q, why do we use RNText here?
Sorry for jumping in here, this looks like it might be a good way to test? :) "Test plan Replace post.indexedAt with the current date (or go back to before the final commit)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backdated post indicator. Requires backend changes to actually work
Test plan
Replace
post.indexedAtwith the current date (or go back to before the final commit)Confirm posts older than 24 hours show the indicator
Confirm that the wording is good