Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve chat performance #6157

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Improve chat performance #6157

merged 2 commits into from
Nov 8, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Nov 8, 2024

Incorrect use of worklet functions in gestures was causing upwards of 7 seconds of delay when rendering chat items

Also fixed accessing UI thread values in render (in hook deps)

Before

Screenshot 2024-11-08 at 03 14 09

After

Screenshot 2024-11-08 at 03 12 39

Test plan

Confirm chats open 2x as fast

Confirm gestures still work (long press + double tap)

@arcalinea arcalinea temporarily deployed to samuel/chat-perf - social-app PR #6157 November 8, 2024 03:15 — with Render Destroyed
Copy link

github-actions bot commented Nov 8, 2024

Old size New size Diff
8.12 MB 8.12 MB -65 B (-0.00%)

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic

@gaearon gaearon merged commit 468c4b8 into main Nov 8, 2024
6 checks passed
@gaearon gaearon deleted the samuel/chat-perf branch November 8, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants