Fix non-home screen soft resetting when feed is selected from right nav #6158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On desktop, when the current feed is selected from the right nav, that performs a soft reset of the current screen. This behavior is expected when the current screen is Home, but it's unnecessary on every other screen since the app will immediately navigate to Home anyway.
In fact, this soft resetting manifested as a bug where selecting the "current" feed (the feed that was last accessed) while on the Search screen will fail to navigate to Home, since soft resetting the Search screen involves a navigation, which cancels the navigation to Home.
I just made it so that it only soft resets on Home, since that's the only place where we want that, I think