Fix: Text keeps going upward and downward when entering a new line on Android #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khuddite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5917
Recording (before & after)
before: android-before.webm
after: android-after.webm
Summary
This issue is cosmetic and happens only on Android. The problem is that when users enter a new line and start typing, the height of the TextInput slightly increases for some reason. It can be annoying to sensitive users because the position of the entire text keeps going up and down.
I did some research, and it seems setting
includeFontPaddingto false fixes the issue. This style is specific to Android and has no implications for iOS. I tested and confirmed this change doesn't affect iOS or other functionalities.https://reactnative.dev/docs/text-style-props#includefontpadding-android