Fix unscrollable body when returning to desktop mode from mobile mode with navigation drawer open. #6201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustSNguyen
changed the title
|
The data flow is kind of backwards here. We shouldn't be setting state in an effect based on some other state — we should instead make the value which decides whether to render the drawer (presumably it's above in this case) the source of truth (or contribute to the source of truth). Is that possible? |
|
I think you can declare |
JustSNguyen
force-pushed
the
fix/fix-locked-body-element-after-resizing
branch
from
72178b6 to
c4ada8e
Compare
|
Oh thanks @gaearon for your feedback, I think that would be better. I have updated the PR. |
gaearon
approved these changes
Nov 11, 2024
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this PR is related to this issue: #6200. Currently, BlueSky blocks the body scroll when the navigation drawer is opened:
social-app/src/view/shell/index.web.tsx
Line 36 in 89c9331
The problem is that when users switch to mobile mode, open the drawer, and then switch back to desktop mode, the navigation drawer is still considered open, which is incorrect. I’ve implemented a quick fix here to automatically close the drawer whenever the user exits mobile mode.