Localize lang selectors according to the app language #6207
Conversation
|
I tested Chinese, Japanese and Korean and they work perfect for me👍 |
|
I haven't tested it exhaustively, but I gave it a quick run in Firefox and it looks good. Because Hermes engine ,iOS and Android use, doesn't seem to support |
|
This is a great idea @Signez 👌 |
| export function languageName(language: Language, appLang: string): string { | ||
| // if Intl.DisplayNames is unavailable on the target, display the English name | ||
| if (!(Intl as any).DisplayNames) { | ||
| return language.name | ||
| } | ||
|
|
||
| return getLocalizedLanguage(language.code2, appLang) || language.name | ||
| } |
There was a problem hiding this comment.
Could this be rewritten as a hook, to avoid needing to pass in langPrefs everywhere?
e.g.
export function useLanguageName(language: Language): string {
const {appLanguage} = useLangPrefs();
...
}
There was a problem hiding this comment.
As hooks shall not be called conditionally, an hypothetical useLanguageName hook could not be used as-is inside .map calls… where most of the existing calls to codeToLanguageName are done.
So yeah, I am not convinced we would gain readability by using a hook here!
|
not gonna do right now but please remind me to look next week |
Signez
force-pushed
the
i18n-language-selector
branch
from
693144a to
5cb5dd7
Compare
|
Just rebased on |
There are two main things that are not yet translatable in Bluesky's UI:
As the second one is quite ironic (don't you think? 🎶) and quite visible on a daily basis, nagging at me as the main translator of Bluesky's app into French with @surfdude29, I thought it would be great to help you out and fix it myself, so you don't have to take time away from your heavy roadmap 😅
In this pull request, I use
Intl.DisplayNameto offer a best-effort translation of the language names, if the browser or target provides it.⬆️ Here, notice the Français language name. It would show French on
main.Of course, I took the time to fix the same problem in the Languages screen:
⬆️ This screen always offered a translation for the app language, and I don't touch it to help anyone revert an unwanted change of app language settings.
Note: This is a best-effort fix: if Expo's runtime on the mobile apps do not support the
Intl.DisplayNames, it will not do anything, and simply show English names as of today.