Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error screen #6235

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix error screen #6235

merged 1 commit into from
Nov 11, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Nov 11, 2024

Error screen height collapsed due to some sort of flexbox issue. I would love to know the root cause, but changing flex_1 to w_full fixes it for now

Before After
Simulator Screenshot 1 Simulator Screenshot 2

Test plan

  • Get to the screen by finding a post with one repost, blocking that person, and then going back to the screen (or edit code to make the query return [])
  • Check it now works on all platforms
  • Confirm that the component still works in other places (i.e. gif select error). It might've changed some screens on native since it's now w_full instead of flex_1, but I can't find any examples

@arcalinea arcalinea temporarily deployed to samuel/collapsed-error-screen - social-app PR #6235 November 11, 2024 15:02 — with Render Destroyed
Copy link

Old size New size Diff
8.01 MB 8.01 MB 0 B (0.00%)

@mozzius mozzius merged commit b85a7da into main Nov 11, 2024
6 checks passed
@mozzius mozzius deleted the samuel/collapsed-error-screen branch November 11, 2024 18:13
@mozzius mozzius restored the samuel/collapsed-error-screen branch November 11, 2024 18:33
@mozzius mozzius deleted the samuel/collapsed-error-screen branch November 11, 2024 18:33
mozzius added a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants