Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize bottom bar icons #6268

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Memoize bottom bar icons #6268

wants to merge 5 commits into from

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Nov 12, 2024

Saved a whole 2ms!

Before After
Screenshot 2024-11-12 at 18 28 17 Screenshot 2024-11-12 at 18 25 42

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

Old size New size Diff
8.02 MB 8.02 MB 1.11 KB (0.01%)

@mozzius mozzius requested review from gaearon and haileyok November 12, 2024 18:38
@arcalinea arcalinea temporarily deployed to samuel/memo-bottom-bar - social-app PR #6268 November 12, 2024 19:42 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/memo-bottom-bar - social-app PR #6268 November 12, 2024 19:42 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/memo-bottom-bar - social-app PR #6268 November 12, 2024 19:50 — with Render Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon Awaiting requested review from gaearon

@haileyok haileyok Awaiting requested review from haileyok

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mozzius @arcalinea