Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove following toast #6272

Closed

Conversation

O4FDev
Copy link
Contributor

@O4FDev O4FDev commented Nov 12, 2024

Why

Removes the following toast when viewing profiles -

  1. The back button is blocked when toasts are displayed (See: https://bsky.app/profile/hlimas.com/post/3la5let3xn42e)
  2. The interaction should be self explanatory (i.e. the button feedback)

What it's not

Not attempting to remove the toast elsewhere outside of the header of profiles

@gaearon
Copy link
Collaborator

gaearon commented Nov 23, 2024

We made toasts draggable instead

@gaearon gaearon closed this Nov 23, 2024
@O4FDev
Copy link
Contributor Author

O4FDev commented Nov 23, 2024

I don't believe this is a complete fix @gaearon - it makes sense from a user perspective still to not have this toast even if you can dismiss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants