[DO NOT MERGE] Change all instances of Reanimated sv.value = to sv.set()
#6273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozzius
changed the title
sv.value = to sv.set()sv.value = to sv.set()
|
arcalinea
temporarily deployed
to
samuel/reanimated-set - social-app PR #6273
Render
Destroyed
|
merged separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: UNSURE IF THIS IS SAFE
Should make React Compiler happier and prevent optimisation bailouts
I've tried to be careful, but I can't be sure these are all correct
Note
It seems as if
.set()must always be called on the UI thread. I've had to move some assignments to within a worklet functionTest plan
Temporarily reenable the lint rule, and see if it stops erroring.
Make sure all the components work the same