[DRAFT + Needs help] Fixes language selector bugs & layout #6275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I'm planning on just getting rid of this component and starting again from scratch, so fyi before you spend too much time on this! |
|
Ah ok! @mozzius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Layout bug:
Select language bug:
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2024-11-12.at.21.04.56.mp4
Remaining problems
Because of the layout of 'other' being a modal, it can be panned down
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2024-11-12.at.21.06.32.mp4
Not really sure how I'm going to fix it, open to suggestions + contributions! :)