Fix inconsistent middle-click behavior for quoted posts #6296
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6280
Summary
Inside the
Linkcomponent, it seems we didn't enableauxclickwhennoFeedbackis false, and that's why middle-click is doing nothing on the post thread page. I figured we probably wanna enableauxclickregardless ofnoFeedbackflag for consistency for all links across the app. (https://developer.mozilla.org/en-US/docs/Web/API/Element/auxclick_event)Solution
Always enable the
auxclickforLinkcomponentRecording
CleanShot.2024-11-13.at.09.01.34.mp4