Tweak shared element animation to make it much smoother #6336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gaearon we talked in DMs about this - lmk if this is something you like or not |
mrousavy
changed the title
|
Ah yes this looks nice. I'll check it locally in a few hours, currently investing Android perf |
gaearon
approved these changes
Nov 14, 2024
|
thanks dan! |
khuddite
pushed a commit
to khuddite/social-app
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It always felt off to me, so I wanted to change it. lmk ur thoughts on this PR.
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-11-14.at.13.48.29.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-11-14.at.13.54.05.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-11-14.at.13.59.41.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-11-14.at.14.00.24.mp4
sorry I'm a bit perfectionistic when it comes to animations.