Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ast" locale support #6411

Merged
merged 13 commits into from
Nov 27, 2024
Merged

Add "ast" locale support #6411

merged 13 commits into from
Nov 27, 2024

Conversation

softastur
Copy link
Contributor

@softastur softastur commented Nov 16, 2024

Asturian is a language spoken in the north-east of Iberian Peninsula by 500000 speakers, and it belongs to the Astur-leonese linguistic branch. This PR adds support for "ast" locale. Translations are 20% completed.

However, we should keep an eye on issue #6346 before merging

@iyanuvieu
Copy link

Yes, please! Let us, asturian language community to spread in BS! 😇

@pfrazee
Copy link
Collaborator

pfrazee commented Nov 23, 2024

Great! TYSM! Is there a native speaker available who could review this?

@softastur
Copy link
Contributor Author

Great! TYSM! Is there a native speaker available who could review this?

Softastur is a non-profit organization which localizes free (as freedom) software into Asturian and it is ran by volunteers. We started our activity in 2003, and Firefox and AOSP are our current biggest projects. We also have our glossary and make use of Academia de la Llingua Asturiana (Academy for Asturian Language) grammar, the only standard for Asturian language, created by Asturian Government in 1980. More info here and here (in Asturian)

softastur and others added 4 commits November 24, 2024 02:16
Fixes minor spelling mistakes and translates many strings more
With this commit we reach the 55% of strings translated after the last code sync
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, very cool! Thanks so much!

@pfrazee pfrazee merged commit 1edebc5 into bluesky-social:main Nov 27, 2024
@@ -42,6 +43,7 @@ interface AppLanguageConfig {
export const APP_LANGUAGES: AppLanguageConfig[] = [
{code2: AppLanguage.en, name: 'English'},
{code2: AppLanguage.an, name: 'Aragonés – Aragonese'},
{code3: AppLanguage.ast, name: 'Asturianu - Asturian'},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work? I don't think the types match up (currently code2 is the required field on this type, and all the application logic also checks for code2 here).

I think this needs a change in the application code to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants