Add manifest.json for basic PWA support #6420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rektide
reviewed
Nov 16, 2024
| } | ||
| ], | ||
| "start_url": "/", | ||
| "display": "standalone", |
There was a problem hiding this comment.
Suggested change
| "display": "standalone", | |
| "display": "standalone", | |
| "display_override": ["tabbed"], |
Since this is a social network app and numerous links are likely to be clicked, my opinion is that we should open with tabs too.
https://developer.chrome.com/docs/capabilities/tabbed-application-mode#using_tabbed_application_mode
There was a problem hiding this comment.
I'm not sure this is a good idea given this property is experimental:
https://developer.mozilla.org/en-US/docs/Web/Manifest/display_override
|
I installed Bluesky as a PWA no tabbed property, and really enjoy it 110% more I used overrides rather than this PR but think it's important a PWA does exist. |
|
MacOS m1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
manifest.jsontobskyweb, allowing the website to be installed as a "WebClip"/PWA application on iOS and iPadOS.This also replaces the
apple-touch-icon.pngwith the application icon, which then renders much better when added as a PWA.Caveats
When running as a standalone PWA on iPhone, the safe area must be supported via the
env(safe-area-inset-*)CSS variables. Unfortunately I wasn't able to quickly make that work together withuseSafeAreaInsetsfromreact-native-safe-area-context.I was also very confused on how
yarn startplays with thebskywebapp. I guess the team is overriding Expo's standard for public assets.To test this, I built the website and started the Go server in
bskyweb.I will add that I am absolutely flabbergasted to have been able to have this working as a logged in user on my local machine. Amazing job on DX!