Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Greek Language ('el') Support and Internationalization #6677

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

imertz
Copy link

@imertz imertz commented Nov 23, 2024

This PR adds full internationalization support for the Greek language, using the ISO 639-1 language code 'el'.

@pfrazee
Copy link
Collaborator

pfrazee commented Nov 23, 2024

Amazing. Are there any native greek speakers available to review this?

@ipinak
Copy link

ipinak commented Nov 24, 2024

@pfrazee I can help with that. Should we ensure all things are translated on this PR or can it be split in smaller PRs?

@auroursa
Copy link
Contributor

@pfrazee I can help with that. Should we ensure all things are translated on this PR or can it be split in smaller PRs?

I think it's beneficial to have a good start for a first translation PR, so it would be best to continue improving this PR until it's ready to be merged.

Copy link

@bekatoros bekatoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comments for changes or additions.

src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
Copy link

@ipinak ipinak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some comments to begin with. Let me know what you think about them.

src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
src/locale/locales/el/messages.po Show resolved Hide resolved
#: src/screens/Settings/components/ChangeHandleDialog.tsx:88
#: src/screens/Settings/components/ChangeHandleDialog.tsx:92
msgid "Change Handle"
msgstr "Αλλαγή Ονόματος"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe ονόματος χρήστη


#: src/components/forms/SearchInput.tsx:70
msgid "Clear search query"
msgstr "Εκκαθάριση ερωτήματος αναζήτησης"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or Καθαρισμός αναζήτησης

#: src/screens/Settings/AboutSettings.tsx:59
#: src/screens/Settings/AboutSettings.tsx:69
msgid "Version {appVersion}"
msgst
Copy link

@dpkgme dpkgme Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Το προφίλ, οι αναρτήσεις, οι ροές και οι λίστες σας δε θα είναι πλέον ορατές σε άλλους χρήστες του Bluesky. Μπορείτε να ενεργοποιήσετε τον λογαριασμό σας ανά πάσα στιγμή πραγματοποιώντας είσοδο.

#: src/screens/Settings/AboutSettings.tsx:59
#: src/screens/Settings/AboutSettings.tsx:69
msgid "Version {appVersion}"
msgst
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Οι αναρτήσεις, τα likes και οι αποκλεισμοί σας είναι δημόσια. Οι σιγάσεις είναι ιδιωτικές.

src/locale/locales/el/messages.po Show resolved Hide resolved
@pfrazee
Copy link
Collaborator

pfrazee commented Nov 27, 2024

Everyone here is amazing -- for the initial translation and the review. I'm going to let this keep cooking because it looks like not everything is resolved yet.


#: src/view/com/notifications/FeedItem.tsx:348
msgid "{firstAuthorName} signed up with your starter pack"
msgstr "{firstAuthorName} εγγεγράφηκε με το starter pack σας"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

γράφτηκε στο starter pack σας

Copy link

@dpkgme dpkgme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Έκανα πάλι ένα πέρασμα.
Προτείνω όπου starter pack => πακέτο έναρξης.
Για τα feeds μάλλον τείνω προς ροές.
Κάτι που με προβληματίζει λίγο είναι η συμπεριληπτικότητα σε κάποια σημεία, π.χ. έχω προτείνει "Θέλετε σίγουρα...;αντί γιαΕίστε σίγουροι...;`. Ας το σκεφτούμε.


#: src/view/shell/bottom-bar/BottomBar.tsx:203
msgid "{0} unread items"
msgstr "{0} ανεπίλυτα στοιχεία"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

αδιάβαστα

src/locale/locales/el/messages.po Show resolved Hide resolved

#: src/view/com/notifications/FeedItem.tsx:326
msgid "{firstAuthorLink} and <0>{additionalAuthorsCount, plural, one {{formattedAuthorsCount} other} other {{formattedAuthorsCount} others}}</0> liked your custom feed"
msgstr "{firstAuthorLink} και <0>{additionalAuthorsCount, plural, one {{formattedAuthorsCount} other} other {{formattedAuthorsCount} άλλοι}}</0> άρεσαν το προσαρμοσμένο feed σας"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

άρεσαν -> άρεσε


#: src/view/com/notifications/FeedItem.tsx:222
msgid "{firstAuthorLink} and <0>{additionalAuthorsCount, plural, one {{formattedAuthorsCount} other} other {{formattedAuthorsCount} others}}</0> liked your post"
msgstr "{firstAuthorLink} και <0>{additionalAuthorsCount, plural, one {{formattedAuthorsCount} other} other {{formattedAuthorsCount} άλλοι}}</0> άρεσαν την ανάρτησή σας"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

άρεσαν -> άρεσε


#: src/view/com/notifications/FeedItem.tsx:234
msgid "{firstAuthorLink} liked your post"
msgstr "{firstAuthorLink} άρεσε την ανάρτησή σας"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

άρεσε η ανάρτησή σας

#: src/view/shell/desktop/LeftNav.tsx:457
#: src/view/shell/Drawer.tsx:476
msgid "Feeds"
msgstr "Τροφοδοσίες"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ροές


#: src/screens/StarterPack/StarterPackScreen.tsx:479
msgid "{0} people have used this starter pack!"
msgstr "{0} άτομα έχουν χρησιμοποιήσει αυτό το starter pack!"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starter pack -> πακέτο έναρξης

src/locale/locales/el/messages.po Outdated Show resolved Hide resolved
src/locale/locales/el/messages.po Outdated Show resolved Hide resolved

#: src/view/com/notifications/FeedItem.tsx:350
msgid "{firstAuthorLink} and <0>{additionalAuthorsCount, plural, one {{formattedAuthorsCount} other} other {{formattedAuthorsCount} others}}</0> signed up with your starter pack"
msgstr "{firstAuthorLink} και <0>{additionalAuthorsCount, plural, one {{formattedAuthorsCount} other} other {{formattedAuthorsCount} άλλοι}}</0> εγγεγράφηκαν με το starter pack σας"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starter pack -> πακέτο έναρξης

@surfdude29
Copy link
Contributor

surfdude29 commented Dec 2, 2024

Would it be possible to add one more change to this PR to enable the Greek localization? If you could add an 'el', entry to app.config.js here please, that would be great:

social-app/app.config.js

Lines 101 to 102 in 770eeb5

'de',
'es',

This will enable Greek to be displayed as a supported language in the App Store listing, and it will also allow the TextInput context menus to be translated into Greek for iOS users who have this set as their device language :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants