Rework scaled dimensions and compression #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renahlee
commented
May 18, 2023
| @@ -13,7 +13,7 @@ async function getFile() { | |||
| .join('/'), | |||
| ) | |||
| const file = files[_imageCounter++ % files.length] | |||
| return await compressAndResizeImageForPost({ | |||
| return await compressIfNeeded({ | |||
There was a problem hiding this comment.
@pfrazee I realize this may not be in line with the original intent but looking at the function, it seems sufficient since we just want any file to use with tests.
pfrazee
approved these changes
May 31, 2023
alimony
added a commit
to alimony/social-app
that referenced
this pull request
May 31, 2023
* main: (31 commits) fix: make DesktopLeftNav not overflow screen (bluesky-social#762) Fix deeplink when app is suspended (bluesky-social#812) Tune sizing of appearance control Remove lodash.clonedeep in package.json (bluesky-social#652) perf: enable lazy loading for tab navigation (bluesky-social#711) Make terms and notices dates less ambiguous. (bluesky-social#713) Use proxy for fetching link meta (bluesky-social#716) feat(Login): allow submitting on password field (bluesky-social#720) show package.json version on web (bluesky-social#717) Add ability to reply, repost (without quote post), and like posts using VoiceOver (bluesky-social#765) Move MAX_GRAPHEME_LENGTH to constants.ts (bluesky-social#735) fix: content trimmed in server input modal (bluesky-social#733) [typo] correct typo was 'fo' instead of 'to' (bluesky-social#721) Rework scaled dimensions and compression (bluesky-social#737) Use non-pipe translation link (bluesky-social#740) add instructions to removing sentry in build.md (bluesky-social#749) Update HomeIconSolid: widen the front door (bluesky-social#756) Support arrow key navigation for Lightbox.web.tsx (bluesky-social#761) Fix profile load issue + enhancement of profile isCurrent style (bluesky-social#764) Update ProfileHeader.tsx (bluesky-social#810) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR:
this.compressedtothis.croppedto reflect the aforementioned changescaleDownDimensionswas causing stretching andcompressAndResizeImageForPostwas scaling up low resolution images and hampering upload)Note: compression now occurs before upload rather than compressing during and after cropping. The major downside to this is not being able to get sync validation if, for example, adding a noisy image with high variance that isn't able to meet the file size limit even after compression.