[APP-657] Add share list functionality #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrazee
approved these changes
Jun 26, 2023
| @@ -97,6 +97,10 @@ export class ListModel { | |||
| return this.list?.creator.did === this.rootStore.me.did | |||
| } | |||
|
|
|||
| get isSubscribed() { | |||
| return this.list?.viewer?.muted | |||
There was a problem hiding this comment.
Is this supposed to be .muted ?
There was a problem hiding this comment.
Oh it might be, right. Just double check me on this.
There was a problem hiding this comment.
yeah for some reason it’s called muted in the lexicon but what it’s really trying to tell us if the user is subscribed to the list or not. the other code also treats it as "subscribed" and puts it in a variable within the components so this getter follows convention.
There was a problem hiding this comment.
yeah I think the logic is "this list is muted". Cool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(currently BLOCKED)no longer blocked, thanks @dholmsTo test, make sure you are on the
ansh/list-embedbranch fromatproto