Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables from env #12

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

mkizka
Copy link
Contributor

@mkizka mkizka commented Sep 6, 2024

Following the README, running npm run dev causes an error. Adding COMMON_RATE_LIMIT_MAX_REQUESTS and COMMON_RATE_LIMIT_WINDOW_MS to the .env file fixes it, but since they are not currently used, I have removed them instead.

$ npm run dev

> atproto-example-app@0.0.1 dev
> tsx watch --clear-screen=false src/index.ts | pino-pretty

/home/ubuntu/playground/statusphere-example-app/node_modules/envalid/src/core.ts:79
          throw new EnvMissingError(formatSpecDescription(spec))
                ^


EnvMissingError: undefined
    at getSanitizedEnv (/home/ubuntu/playground/statusphere-example-app/node_modules/envalid/src/core.ts:79:17)
    at cleanEnv (/home/ubuntu/playground/statusphere-example-app/node_modules/envalid/src/envalid.ts:18:34)
    at dotenv (/home/ubuntu/playground/statusphere-example-app/src/lib/env.ts:6:20)
    at Object.<anonymous> (/home/ubuntu/playground/statusphere-example-app/src/lib/env.ts:18:2)
    at Module._compile (node:internal/modules/cjs/loader:1504:14)
    at Object.transformer (/home/ubuntu/playground/statusphere-example-app/node_modules/tsx/dist/register-C1urN2EO.cjs:2:1122)
    at Module.load (node:internal/modules/cjs/loader:1282:32)
    at Module._load (node:internal/modules/cjs/loader:1098:12)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:215:24)

Node.js v22.5.1

@gaearon gaearon merged commit 9cd25e3 into bluesky-social:main Sep 9, 2024
@gaearon
Copy link

gaearon commented Sep 9, 2024

thanks for the fix!

@mkizka mkizka deleted the remove-unused-env branch September 9, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants