Show button when landed on page with anchor #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi and thanks for the Pull Request. Quick question though... I've not come across an issue with Anchors so far. Could you give me an example where it's causing issues? Or is it a browser-specific thing? Thanks! |
|
I have just created a test site on a fresh Yii install, only your addon is enabled. If you visit link removed you will notice you reached the bottom of the page. However, no button is displayed until you manually scroll a little bit. Hope this helps you |
|
Great! Thanks 👍 |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When landing halfway on a page by means of an anchor the button would not show. This change will fix that behavior.