Add ArrayVec::drain_filter() #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks good! unstable drain_filter in Rust seems a bit volatile, so I'd like to avoid merging this until we are confident it matches the upstream shape of the API. The alternative would be to merge it, but remove it in arrayvec 1.0. |
|
Makes sense. Let's put it on hold. |
|
Hm, still no movement on the tracking issue. |
|
Possibly relevant, one day: rust-lang/rust#61224 |
|
Will have to be rewritten, when the time comes (due to merge conflicts). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
drain_filter()with an implementation similar to Vec's nightlydrain_filter(). Can also be used to simplifyretain().