This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat: new WriteTo method. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is makes the EPUB structu fulfiling the io.WriterTo interface
A lot of panic functions are encapsulating into return error. This makes it easier to catch the exit door of the function.
|
Looks great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As exposed in #52 , I introduce this method to write the zipfile to an
io.Writer.This can be helpful if the EPUB generation is embedded in a webserver for example.
This PR introduces the
WriteTo(w io.Writer) (int64, error)method to the EPUB structure.The EPUB structure is therefore fulfilling the
io.WriterTointerface.The
Writemethod has been modified to use this new method. Thedestinationis a file created within the Write method.The existing tests should be enough to validate the new method. I added one new test to validate the counter of the bytes written.