Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tcp disconnect doesn't emit an error on tcpConnection #41

Open
nicdex opened this issue Aug 26, 2015 · 5 comments
Open

Tcp disconnect doesn't emit an error on tcpConnection #41

nicdex opened this issue Aug 26, 2015 · 5 comments

Comments

@nicdex
Copy link

nicdex commented Aug 26, 2015

When the underlying tcp connection is disconnected by an error the error doesn't bubble up to the tcpConnection.

Right now there is no way to know that we are disconnected, so we can't take any compensating actions.

I think I could submit a PR for this one.

@gregoryyoung
Copy link

In the other clients we have events that get passed back and we have
reconnection etc strategies to prevent people from writing the same
boilerplate.

On Wed, Aug 26, 2015 at 7:41 PM, Nicolas Dextraze notifications@github.com
wrote:

When the underlying tcp connection is disconnected by an error the error
doesn't bubble up to the tcpConnection.

Right now there is no way to know that we are disconnected, so we can't
take any compensating actions.

I think I could submit a PR for this one.


Reply to this email directly or view it on GitHub
#41.

Studying for the Turing test

@bmavity
Copy link
Owner

bmavity commented Aug 26, 2015

Things stalled a bit before I got to the connection events. I am preparing
a new release, but can't promise if connection events would get in.
However, I would not be opposed to a pull request. :)

B

On Wed, Aug 26, 2015 at 11:42 AM, Greg Young notifications@github.com
wrote:

In the other clients we have events that get passed back and we have
reconnection etc strategies to prevent people from writing the same
boilerplate.

On Wed, Aug 26, 2015 at 7:41 PM, Nicolas Dextraze <
notifications@github.com>
wrote:

When the underlying tcp connection is disconnected by an error the error
doesn't bubble up to the tcpConnection.

Right now there is no way to know that we are disconnected, so we can't
take any compensating actions.

I think I could submit a PR for this one.


Reply to this email directly or view it on GitHub
#41.

Studying for the Turing test


Reply to this email directly or view it on GitHub
#41 (comment).

@nicdex
Copy link
Author

nicdex commented Aug 26, 2015

Yeah Greg I know.

For now I only want to have the error bubble up as a start, but eventually it would be nice to have the reconnect done by the ges-client too.

We're about to go into alpha for our product today using ges-client and GES so I guess we'll see a lot of issues. I'll try to get the OK to submit PR fixes for issues we see and can fix.

Thanks.

@bmavity
Copy link
Owner

bmavity commented Aug 26, 2015

It's part of the "plan".

@bmavity
Copy link
Owner

bmavity commented Aug 31, 2015

Created a parent issue for all issues awaiting Connection work #44

@bmavity bmavity self-assigned this Sep 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants