-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix/housekeeping] CDN Update issue, [AUTO] Bump Version Tag? #33
Comments
I have issued a new release on github which I think should sort this out, if you can wait a bit and then check again / confirm that would be awesome. Also, I was thinking since we've got the auto-build for the min setup now with your contribution, perhaps it makes sense to auto release a version when it sees a version bump? or maybe this is best handled manually as to not flood the versions? any thoughts on that? |
yes, I'm open to this for sure. I've never tagged from the command line so I'm partial to the So the gh action on release created would ideally:
I'm re-opening this issue to address this new idea/issue |
Thoughtactually i think every commit should get its own patch versionand major and minor version bumps should be manualreasoning:Auto bump every commitPro:
Manual version bump on group of stable commits:Pro:
Con:
Clarification: what I was thinking what would happen:
Question:
|
Ill make a pull request with a the code that auto bumps the version number on creation of release tag |
Done code should be here #38 |
Auto update version number on every commit [#33]
Issue:
Hi @bmoren! i was testing out code with the latest vector pull request merged #28 , looks like CDN's doesn't register the change because the version number hasnt been updated.
Solution:
Add a updated tag to reflect the change
Link to Example of cdn not updating issue
Photos of issue
The text was updated successfully, but these errors were encountered: