Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/housekeeping] CDN Update issue, [AUTO] Bump Version Tag? #33

Closed
wisehackermonkey opened this issue Jun 24, 2020 · 7 comments
Closed

Comments

@wisehackermonkey
Copy link
Contributor

Issue:

Hi @bmoren! i was testing out code with the latest vector pull request merged #28 , looks like CDN's doesn't register the change because the version number hasnt been updated.

Solution:

Add a updated tag to reflect the change

v0.6 -> v0.7 

Link to Example of cdn not updating issue

Photos of issue

image.png

image.png
image.png

@bmoren
Copy link
Owner

bmoren commented Jun 24, 2020

I have issued a new release on github which I think should sort this out, if you can wait a bit and then check again / confirm that would be awesome. Also, I was thinking since we've got the auto-build for the min setup now with your contribution, perhaps it makes sense to auto release a version when it sees a version bump? or maybe this is best handled manually as to not flood the versions? any thoughts on that?

@bmoren
Copy link
Owner

bmoren commented Jun 25, 2020

@bmoren bmoren closed this as completed Jun 25, 2020
@wisehackermonkey
Copy link
Contributor Author

Auto bumping the version numbers on git tag creation

sounds like a good idea.

workflow diagram

heres what i was thinking


I think there is a github action for that specific task, so it might be a easy change

@bmoren
Copy link
Owner

bmoren commented Jun 30, 2020

yes, I'm open to this for sure. I've never tagged from the command line so I'm partial to the release created > gh action idea. I think this could also be combined with the current minify action so that it's not happening every commit, but instead when a version is explicitly ready for a release. This would avoid polluting the minified version while updates are being made to the verbose version.

So the gh action on release created would ideally:

  • bump version #s (based on the release tag?)
  • minify
  • publish version update to NPM (does this happen automatically?)

I'm re-opening this issue to address this new idea/issue

@bmoren bmoren reopened this Jun 30, 2020
@bmoren bmoren changed the title [Fix/housekeeping] CDN Update issue, Bump Version Tag [Fix/housekeeping] CDN Update issue, [AUTO] Bump Version Tag? Jun 30, 2020
@wisehackermonkey
Copy link
Contributor Author

Thought

actually i think every commit should get its own patch version

and major and minor version bumps should be manual

reasoning:

Auto bump every commit

Pro:

  • major versions should break compatibility [Manual]
  • minor version dont break compatibility but add features [Manual]
  • patches fix bugs [Automatic]
    Con:
  • patch bug fixes wont go be delivered through cdn's

Manual version bump on group of stable commits:

Pro:

  • cdn's will get bug fixes and small updates and the user doesn't have to change the code
  • cleaner version numbers

Con:

  • a change to the code could break compatibility with people's existing projects
  • more hands on, mantainnes

Clarification:
gh action is the build script

what I was thinking what would happen:

  • create release tag for major and minor version bumps [manual]

via here or in the command line using git tag X.X.X

  • github action build script is triggered [automatically]
  • bump version #s based on the release tag [automatically]
  • minify [automatically]
  • publish version update to NPM [automatically]

Question: publish version update to NPM (does this happen automatically?)

Answer: its automatic based on the latest git tag

@wisehackermonkey
Copy link
Contributor Author

Ill make a pull request with a the code that auto bumps the version number on creation of release tag

@wisehackermonkey
Copy link
Contributor Author

Done code should be here #38

bmoren added a commit that referenced this issue Jul 2, 2020
Auto update version number on every commit [#33]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants