Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperterm-mactabs plugin #37

Merged
merged 3 commits into from
Jul 24, 2016
Merged

Add hyperterm-mactabs plugin #37

merged 3 commits into from
Jul 24, 2016

Conversation

insanityfarm
Copy link
Contributor

@insanityfarm insanityfarm commented Jul 19, 2016

Checklist:

  • The title for my package or theme uses its npm title (hyperterm-plugin-example)
  • The link for my package or theme uses the npmjs.com link (https://npmjs.com/package/hyperterm-plugin-example)
  • There is a visual representation of what my plugin does in the repo. (Plugin: screenshot or gif || Theme: screenshot of the colors within HyperTerm)
  • VERY IMPORTANT: I've written a short (one sentence) description for my package or theme of why it's awesome and deserves to be on the list.

Made it one sentence instead of two for compliance with awesome-hyperterm contribution guidelines.
@insanityfarm
Copy link
Contributor Author

Before merging this pull request, please take a look at issue #38 which I just created. I'd like to make sure I took a reasonable approach when building this plugin and get some feedback from the community.

Shortly after publishing the `hyperterm-maclite` theme I went back to the drawing board and changed it into the `hyperterm-mactabs` package. This one is intended to be compatible with other themes and only affects tab styles.
@insanityfarm
Copy link
Contributor Author

Okay, I think I'm satisfied for now. Please take a look and consider merging this PR if it's a good contribution.

@insanityfarm insanityfarm changed the title Added hyperterm-maclite theme Add hyperterm-mactabs plugin Jul 20, 2016
@bnb bnb merged commit 60dab8c into bnb:master Jul 24, 2016
@bnb
Copy link
Owner

bnb commented Jul 24, 2016

Merged! Thanks for the awesome contribution!

@bnb bnb added the bug label Jul 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants