Skip to content

Migrate to using Terraform Deployment #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 70 commits into from
May 20, 2019
Merged

Migrate to using Terraform Deployment #46

merged 70 commits into from
May 20, 2019

Conversation

bhavikkumar
Copy link
Member

This uses a completely new method of deployments. It is utilising Terraform for the entire deployment, the benefits are:

  • Single ECR Repository.
  • Exactly the same infrastructure configuration deployed to development and production.
  • Resources are created as part of the deployment stages (no requirement to run CloudFormation before being able to deploy).
  • Waits until the service is stable before marking the deployment as successful.
  • Ability to reference other terraform projects for resources.
  • Platform agnostic (will work on Linux, Windows or OSX machines).

guobaorou1989 and others added 30 commits May 13, 2019 11:11
@guobaorou1989
Update to use session token
b899617
@guobaorou1989
Add terraform files to create ecr repository
641169d
@guobaorou1989
Add Terraform ECR build config to TravisCI
828b861
@guobaorou1989
Remove condition from init ecr stage
8e3226b
@guobaorou1989
Provide stage ordering to Travis-CI
2d17cdb
@guobaorou1989
Add terraform binary to bin folder
f335fb3
@guobaorou1989
Use terraform instead of ./terraform
cd8bcf1
@guobaorou1989
Add backend key
0bea518
@guobaorou1989
Tag and push docker image
b22c7ae
@guobaorou1989
Only run against openjdk11
c9bc195
@guobaorou1989
Use xenial instead of trusty
c9ab640
@guobaorou1989
Switch to travis build dir instead of home directory
190d7c4
@guobaorou1989
Use snap to install awscli
b89aa04
@guobaorou1989
Fix snap install issue
d3e5eb6
@guobaorou1989
Use dockerTagsPush to push both latest and with travis number
933f0a4
@guobaorou1989
Add dockerPush to push the latest docker image
774ce3b
@guobaorou1989
Add dockerPush to push the latest docker image
21413d8
@bhavikkumar
Simplify deploys to use single deployment user
cda704a
@bhavikkumar
Remove pip and ecs deploy as they will not be used for future deploys
ac42660
@bhavikkumar
Move switch role into correct location
0235177
@bhavikkumar
Update the principal allowed to write to the ECR repository
128f322
@bhavikkumar
Fix role session name having invalid characters
0db9c96
@bhavikkumar
Print out assumed user info
9c365a8
@bhavikkumar
Removed [secure] from env variables
b7de3be
@bhavikkumar
Fix up role session name
dbb95db
@bhavikkumar
Remove AWS_INFO env variable
aae51c6
@bhavikkumar
Fix client artifact group to include root project name
17057da
@bhavikkumar
Add dev and prod role arns
5222577
@bhavikkumar
Remvoe unrequired Travis AWS credentials
fc457ea
@bhavikkumar
Update assume role command
a10062c
bhavikkumar and others added 19 commits May 17, 2019 17:58
@pushkar-g
Copy link
Contributor

Looks good. Is there plan to support fargate based deployment as well?

@bhavikkumar bhavikkumar merged commit cbcacb1 into master May 20, 2019
@bhavikkumar bhavikkumar deleted the single_ecr_repo branch May 20, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangyi733 zhangyi733 zhangyi733 approved these changes

@alphafoobar alphafoobar Awaiting requested review from alphafoobar

@vwen01 vwen01 Awaiting requested review from vwen01

@suryakakanadan suryakakanadan Awaiting requested review from suryakakanadan

@joelmozhu joelmozhu Awaiting requested review from joelmozhu

+1 more reviewer

@pushkar-g pushkar-g pushkar-g approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhavikkumar @pushkar-g @zhangyi733 @guobaorou1989