Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usefull warning if multiple testsrc, bin or test bins are defined #5959

Closed
juergen-albert opened this issue Jan 9, 2024 · 6 comments · Fixed by #6057
Closed

Add usefull warning if multiple testsrc, bin or test bins are defined #5959

juergen-albert opened this issue Jan 9, 2024 · 6 comments · Fixed by #6057
Assignees

Comments

@juergen-albert
Copy link
Contributor

Right now, src can have multiple entries. testsrc however can not. As src supports this, one expects testsrc to do as well. If you use it though bndtools starts to complain and you will not deduce the issue without deeper bnd knowledge.

To stay in sync with eclipse, we should support multiple bin folders as well, while we are at it.

@pkriens
Copy link
Member

pkriens commented Jan 9, 2024

It is a major change. I looked into this a couple of years ago because the testsrc (and the macro names itself) annoyed me. But it is non-trivial. Also, I am not sure what the purpose of multiple test src folders really is. And I have a hard time wrapping my head around the idea of multiple bin folders, just even more misery to handle split packages?

They are not nearly as useful as the multple src folders. We also have to consider other envs than Eclipse and this might make it harder for no obvious benefit.

@pkriens
Copy link
Member

pkriens commented Jan 23, 2024

I do not see this as feasible any time soon. Ok if I close this and move to abeyance?

@juergen-albert
Copy link
Contributor Author

Multiple bins (besides test and no test) don't make sense either. For source folder is makes sense however. Especially, when you have generated code and normal code in the same bundle. We e.g. often have a src and src-gen folder. We concretely stumbled upon the issue, as we had some generated test code next to the written one.

If you say that such a change is not trivial, that is okay. I would suggest, that we at least produce a warning in such a case, because it looks as if it should work, but the results are strange. I'll implement a useful warning for that.

@juergen-albert juergen-albert self-assigned this Jan 25, 2024
@juergen-albert
Copy link
Contributor Author

BTW: Regarding the bin and test bin, my thinking has been, that we should support the same behavior everywhere. I don't really see the need for it as well.

@juergen-albert juergen-albert changed the title Allow for multiple testsrc, bin and testbin entries Add usefull warning if multiple testsrc, bin or test bins are defined Jan 25, 2024
@pkriens
Copy link
Member

pkriens commented Jan 26, 2024

that does make sense

@pkriens
Copy link
Member

pkriens commented Mar 15, 2024

any movement over here?

pkriens added a commit to pkriens/bnd that referenced this issue Mar 18, 2024
…Fixes bndtools#5959

---
 Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>

Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants