Issues/5346 fixes #5583
Merged
Issues/5346 fixes #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
It was noted by laeubi that * it always generated a module-info.class for a release version * the requirements were always additive for subsequent releases This was my practical understanding but he made a test case that actually leveraged a unique analysis per released version. Unfortunately, we need to do each analysis from scratch, something I'd hoped to prevent. This made the copy functions for Analyzer, Jar, etc. superfluous so I removed those for now. Module info class is now only generated when * the instruction is properly set for the main jar * there is no module-info.class in the release version --- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noted by laeubi that
This was my practical understanding but he made a test case
that actually leveraged a unique analysis per released version.
Unfortunately, we need to do each analysis from scratch, something
I'd hoped to prevent.
This made the copy functions for Analyzer, Jar, etc. superfluous so
I removed those for now.
Module info class is now only generated when