Java Imports & Empty header #5588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The java imports are now always done except when the used framework is < 1.9 (before R7). The EE version is now ignored. - The version used to come from the _imports_. However, that does not make sense, so I've changed it to the classpathExports version of the framework package. This is in almost all cases the floor of the import range. By using the export, we can make the decision that we use an old framework in any bundle that has the framework package on the class path and not only in bundles that import the framework. (Surprised this was not a problem?) - The MRJ will now set the Input-Package to Require-Capability to an empty string since the spec is rather strange imho. The RFC is a tiny bit clearer but this case should be made more explicit. --- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5585
The PR #5581 can now be tried again after this is merged
Signed-off-by: Peter Kriens Peter.Kriens@aQute.biz