-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of BndEditModel #6082
Update of BndEditModel #6082
Conversation
Now properly reflects the inheritance structure of Processor chains --- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
--- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The changes to my code seem minor. test.ProcessorTest.testPropertyKeysFindVisibles()
seems still working.
Besides my comment about the javadoc of findVisibles()
I have nothing else.
I checked out the code locally and did a few manuial tests. still working.
I saw the warning. I could also not find it. Will investigate |
Found the warning. You added two lines to the
The ${.} is a very special macro. It is handled with included files during inclusion because we know the file location then. In the pre processing of a file with the macro processor we have no idea where we are. We might want to think about supporting this in the |
--- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
--- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
Misunderstood the use of the ${.}. It had to be escaped and i think you do not want to have cnf in the path. ${.} refers to the directory of the preprocessed file. |
Thanks for finding this. |
Now properly reflects the inheritance structure of Processor chains
@chrisrueger I made a few changes to your code, please verify
Signed-off-by: Peter Kriens Peter.Kriens@aQute.biz