Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of BndEditModel #6082

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Update of BndEditModel #6082

merged 4 commits into from
Apr 19, 2024

Conversation

pkriens
Copy link
Member

@pkriens pkriens commented Apr 10, 2024

Now properly reflects the inheritance structure of Processor chains

@chrisrueger I made a few changes to your code, please verify

Signed-off-by: Peter Kriens Peter.Kriens@aQute.biz

Now properly reflects the inheritance structure of Processor chains

---
 Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>

Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
---
 Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>

Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
Copy link
Contributor

@chrisrueger chrisrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The changes to my code seem minor. test.ProcessorTest.testPropertyKeysFindVisibles() seems still working.
Besides my comment about the javadoc of findVisibles() I have nothing else.

I checked out the code locally and did a few manuial tests. still working.

@chrisrueger
Copy link
Contributor

I noticed one new warning recently, but could not figure out when it came in:

image
Description	Resource	Path	Location	Type
No translation found for macro: .	bnd.bnd	/bndtools.core	line 1	Bndtools Problem Marker

@pkriens
Copy link
Member Author

pkriens commented Apr 11, 2024

I saw the warning. I could also not find it. Will investigate

@pkriens
Copy link
Member Author

pkriens commented Apr 19, 2024

Found the warning. You added two lines to the _plugin.xml with ${.}:

		    <property name="pom" type="string" description="Points to a pom.xml file. This is exclusive with revision. Can be a comma separated list of files." default="${workspace}/cnf/pom.xml" />

The ${.} is a very special macro. It is handled with included files during inclusion because we know the file location then. In the pre processing of a file with the macro processor we have no idea where we are.

We might want to think about supporting this in the -includeresource process ...

---
 Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>

Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
---
 Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>

Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
@pkriens
Copy link
Member Author

pkriens commented Apr 19, 2024

Misunderstood the use of the ${.}. It had to be escaped and i think you do not want to have cnf in the path. ${.} refers to the directory of the preprocessed file.

@pkriens pkriens merged commit d2fc304 into bndtools:master Apr 19, 2024
9 checks passed
@chrisrueger
Copy link
Contributor

Misunderstood the use of the ${.}. It had to be escaped and i think you do not want to have cnf in the path. ${.} refers to the directory of the preprocessed file.

Thanks for finding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants