R CMD check happiness on gcc-8 (-Wstringop-truncation)

bnosac · Sep 11, 2018 · 19412d0 · 19412d0
1 parent b7a92ca
commit 19412d0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/R/modelling.R b/R/modelling.R
@@ -144,6 +144,7 @@ crf <- function(x, y, group,
 #' @export
 as.crf <- function(file, ...){
   ldots <- list()
+  stopifnot(file.exists(file))
   object <- crfsuite_model(file)
   for(element in c("method", "type", "options", "attribute_names", "log", "FUN", "ldots")){
     object[[element]] <- ldots[[element]]

diff --git a/src/cqdb/src/cqdb.c b/src/cqdb/src/cqdb.c
@@ -267,7 +267,10 @@ int cqdb_writer_close(cqdb_writer_t* dbw)
     }
 
     /* Initialize the file header. */
-    strncpy((char*)header.chunkid, CHUNKID, 4);
+    // Make R CMD check happy
+    // strncpy((char*)header.chunkid, CHUNKID, 4);
+    memcpy((char*)header.chunkid, CHUNKID, 4);
+    // END make R CMD check happy
     header.flag = 0;
     header.byteorder = BYTEORDER_CHECK;
     header.bwd_offset = 0;
@@ -466,7 +469,10 @@ cqdb_t* cqdb_reader(const void *buffer, size_t size)
 
         /* Read the database header. */
         p = db->buffer;
-        strncpy((char*)db->header.chunkid, (const char*)p, 4);
+        // Make R CMD check happy
+        //strncpy((char*)db->header.chunkid, (const char*)p, 4);
+        memcpy((char*)db->header.chunkid, (const char*)p, 4);
+        // END make R CMD check happy
         p += sizeof(uint32_t);
         db->header.size = read_uint32(p);
         p += sizeof(uint32_t);