Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Witcher 3 HBAO+ normal map artifacts #54

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Conversation

mx-2
Copy link
Contributor

@mx-2 mx-2 commented Nov 23, 2016

I fixed HBAO+ normal map artifacts in The Witcher 3 with DarkStarSwords pattern from https://forums.geforce.com/default/topic/897529/3d-hbao-normal-map-artefact-fix.

The fix is FOV aware as the game changes it depending on the situation. Required constant buffers are copied from the parent vertex shader which seems to have the same layout as register b12 in f9c83c25de6eaa51-ps_replace. Nevertheless some fudge constant of 1.5 seems to be necessary.

@helifax
Copy link
Collaborator

helifax commented Nov 23, 2016

Awesome!
Big thanks for this;)
I saw it before but wasn't able to properly find it;)
This is the thing that affects the normal Map used in special effects like the freezing bomb? (North Star, If I recall it right)

I'll make the merge;) in any case;)
Big thank you again!

@helifax helifax merged commit 420789a into bo3b:master Nov 23, 2016
@mx-2
Copy link
Contributor Author

mx-2 commented Nov 25, 2016

Until now, I used the Northern Wind only a few times so I didn't noticed that issues.
I tried it out today and saw some issues eg. on frozen grass that are still there with my fix so there must be another shader.

For your information:
I found the broken shader very fast with the great frame analysis feature;)

@helifax
Copy link
Collaborator

helifax commented Nov 27, 2016

Awesome!
When you want it to merged in the fix, do let me know;)
I'll re-pack everything then;)

Thank you!

@bo3b
Copy link
Owner

bo3b commented Nov 27, 2016

When you repack it, please also change to the 1.2.48 version, and add the

allow_dxgi1_2=2

as: https://forums.geforce.com/default/topic/546943/3d-vision/the-witcher-3-wild-hunt/post/5022007/#5022007

That fixes a problem with Steam Overlay running.

@bo3b
Copy link
Owner

bo3b commented Nov 27, 2016

Also worthwhile change from: https://forums.geforce.com/default/topic/546943/3d-vision/the-witcher-3-wild-hunt/post/4947981/#4947981

To allow the TB/SBS support to use the F11 key to change modes, remove the F11 usage from the HBA0+ disable. Or move that disable toggle for HBA0+ fix to a different key. We are standardizing on F11 for TB/SBS across all games.

@DarkStarSword
Copy link
Collaborator

I am pretty sure that we don't even need the HBAO+ toggle any more - that was originally a workaround for a driver bug to keep the game playable until the user could save and restart. I haven't heard any reports of that bug in ages, so it's probably safe to assume it has been fixed and we can remove the workaround.

@helifax
Copy link
Collaborator

helifax commented Dec 1, 2016

Yes, I don't use the F11 for the HBAO+.
I still use the other key for SLI water reflections though;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants