Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve health checks for Bob #28

Closed
lispyclouds opened this issue Mar 6, 2019 · 2 comments
Closed

Improve health checks for Bob #28

lispyclouds opened this issue Mar 6, 2019 · 2 comments
Assignees
@TimoKramer
Labels
enhancement good first issue

Comments

@lispyclouds
Copy link
Member

lispyclouds commented Mar 6, 2019 •
edited
Loading

Check all sub systems on GET /api/can-we-build-it

Checks:

  • Docker is reachable and anwsers positively on ping
  • H2 is operational
@TimoKramer
Copy link
Member

I would use a 503 as return code when the health check failed since it seems the best fit (https://tools.ietf.org/html/rfc7231#section-6.6.4) 5xx are server failures and 503 is service unavailable.

@lispyclouds
Copy link
Member Author

sounds good!

TimoKramer added a commit to TimoKramer/bob that referenced this issue Aug 30, 2019
@TimoKramer
bob-cd#28 health check for bob
e312a00
TimoKramer added a commit to TimoKramer/bob that referenced this issue Aug 30, 2019
@TimoKramer
bob-cd#28 better error response
47e86cd
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 2, 2019
@TimoKramer
bob-cd#28 health check for bob
a779eaf
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 2, 2019
@TimoKramer
bob-cd#28 better error response
e92c0c4
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 2, 2019
@TimoKramer
bob-cd#28 first working draft, tests to do
74fb4c6
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 2, 2019
@TimoKramer
bob-cd#28 health check for bob
6571bf9
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 2, 2019
@TimoKramer
bob-cd#28 better error response
f3948e1
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 8, 2019
@TimoKramer
bob-cd#28 first working draft, tests to do
e948c50
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 8, 2019
@TimoKramer
bob-cd#28 health check for bob
afd6643
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 8, 2019
@TimoKramer
bob-cd#28 better error response
a41f8e3
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 8, 2019
@TimoKramer
bob-cd#28 inlined functions for better readability
cfe0729
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 8, 2019
@TimoKramer
bob-cd#28 logging and proper return message but not multiple errors p…
d8a8353 
…ossible
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 8, 2019
@TimoKramer
bob-cd#28 logging and proper return message but not multiple errors p…
bf329ce 
…ossible
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 10, 2019
@TimoKramer
Improve Health Check Tests
ee44d2e 
- Addresses bob-cd#28
- constantly instead of anonymous functions
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 10, 2019
@TimoKramer
Returning multiple failing systems on health check
c5b631c 
- Addresses bob-cd#28
- not only the first failing system is returned
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 10, 2019
@TimoKramer
bob-cd#28 first working draft, tests to do
53a373f
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 10, 2019
@TimoKramer
bob-cd#28 health check for bob
3b0bd2a
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 10, 2019
@TimoKramer
bob-cd#28 better error response
ab5c830
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 10, 2019
@TimoKramer
bob-cd#28 inlined functions for better readability
a401c0a
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 10, 2019
@TimoKramer
bob-cd#28 logging and proper return message but not multiple errors p…
63ceae6 
…ossible
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 10, 2019
@TimoKramer
Improve Health Check Tests
81af807 
- Addresses bob-cd#28
- constantly instead of anonymous functions
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 10, 2019
@TimoKramer
Returning multiple failing systems on health check
f30cbda 
- Addresses bob-cd#28
- not only the first failing system is returned
TimoKramer added a commit to TimoKramer/bob that referenced this issue Sep 10, 2019
@TimoKramer
Returning multiple failing systems on health check
e37d806 
- Addresses bob-cd#28
- not only the first failing system is returned
- logging implemented
lispyclouds pushed a commit that referenced this issue Sep 11, 2019
@TimoKramer @lispyclouds
#28 improve health checks for bob (#50)
fbfba00
lispyclouds pushed a commit that referenced this issue Sep 11, 2019
@TimoKramer @lispyclouds
Improve health checks for bob (#50)
5c3bd81 
- Closes #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimoKramer TimoKramer

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimoKramer @lispyclouds